Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parameter declarations from yaml to within class definitions #162

Open
itrharrison opened this issue Nov 13, 2023 · 1 comment
Open

Move parameter declarations from yaml to within class definitions #162

itrharrison opened this issue Nov 13, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation repo Related to repo functionality
Milestone
November Hack

Comments

@itrharrison
Copy link
Collaborator

Rather than having parameter and option declarations within the Likelihood.yaml files we should move them to within the class definitions.

This will fix errors with apparently undeclared variables, make it easier to document the options, allow us to stop having to explicitly include them in [options.package_data]...
@itrharrison itrharrison added documentation Improvements or additions to documentation repo Related to repo functionality labels Nov 13, 2023
@itrharrison itrharrison added this to the November Hack milestone Nov 13, 2023
@itrharrison
Copy link
Collaborator Author

itrharrison commented Nov 14, 2023 •
edited
Loading

List of places to at least look at removing this:

  • Linear_bias.yaml
  • Foreground.yaml
  • CosmoPowerDerived.yaml
  • CosmoPower.yaml
  • CCL.yaml
  • Bias.yaml
  • BandPass.yaml
  • clusters/ClusterLikelihood.yaml
  • cross_correlation/CrossCorrelationLikelihood.yaml
  • cross_correlation/GalaxyKappaLikelihood.yaml
  • cross_correlation/ShearKappaLikelihood.yaml
  • halo_model/HaloModel.yaml
  • halo_model/HaloModel_pyhm.yaml
  • mflike/MFLike.yaml
  • mflike/TheoryForge_MFLike.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation repo Related to repo functionality
Projects
None yet
Milestone
November Hack
Development

When branches are created from issues, their pull requests are automatically linked.

162-move-param-declarations simonsobs/SOLikeT
1 participant
@itrharrison