Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vantage agent changes #531

Open
jlashner opened this issue Sep 23, 2023 · 2 comments
Open

Vantage agent changes #531

jlashner opened this issue Sep 23, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jlashner
Copy link
Collaborator

A few changes and additions we'd like in the vantage agent based on current usage:

  • UVI is off by a factor of ten
  • UVI overflows if it goes above 127. We should have the agent automatically convert negative UVIs to the value they would be if they were an unsigned int.
  • Temp is in fahrenheit but we'd like celsius
  • We'd like an estimate of the wind-chill / wind-chill-temp. We may be able to just do this in grafana with existing data
@BrianJKoopman BrianJKoopman added bug Something isn't working enhancement New feature or request labels Sep 26, 2023
RemingtonGerras added a commit that referenced this issue Oct 6, 2023
@RemingtonGerras
Addressed Issue #531
020c268
@RemingtonGerras RemingtonGerras mentioned this issue Oct 6, 2023
Merged
6 tasks
BrianJKoopman pushed a commit that referenced this issue Oct 11, 2023
@RemingtonGerras @pre-commit-ci
Address (most of) Issue #531 (#539)
e021f7a 
* Address Issue #531

* Correct UVI overflow calculation

* Write fahrenheit to celsius conversion function to use when collecting temperature data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@BrianJKoopman
Copy link
Member

Mostly solved by #539. If we're fine with estimating wind-chill / wind-chill-temp in Grafana this can be closed.

mhasself pushed a commit that referenced this issue Oct 16, 2023
@RemingtonGerras @pre-commit-ci @mhasself
Address (most of) Issue #531 (#539)
8819269 
* Address Issue #531

* Correct UVI overflow calculation

* Write fahrenheit to celsius conversion function to use when collecting temperature data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@RemingtonGerras RemingtonGerras mentioned this issue Oct 17, 2023
Merged
6 tasks
@BrianJKoopman BrianJKoopman mentioned this issue Mar 1, 2024
Merged
6 tasks
@BrianJKoopman
Copy link
Member

Wind chill was added in #550. I had to revert the UVI factor of 10 fix in #636, due to the fact that since an integer was already published, InfluxDB rejects the new float values. I think it would be fine to continue to publish integers and just divide by 10 for display in Grafana. Let me know if that's still a problem.

hnakata-JP pushed a commit that referenced this issue Apr 12, 2024
@RemingtonGerras @pre-commit-ci @d-hoshino2626
Address (most of) Issue #531 (#539)
74d6a43 
* Address Issue #531

* Correct UVI overflow calculation

* Write fahrenheit to celsius conversion function to use when collecting temperature data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlashner @BrianJKoopman