Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict ACU elevation check in HWP supervisor restricts normal operation #788

Open
BrianJKoopman opened this issue Nov 3, 2024 · 0 comments
Assignees
Labels
agent: hwp supervisor bug Something isn't working

Comments

@BrianJKoopman
Copy link
Member

During normal operations the ACU encoder readout will sometimes be past the min/max elevation by a tiny amount. This can limit a typical scan. For example:

2024-11-03T14:34:06+0000 start called for pid_to_freq
2024-11-03T14:34:06+0000 pid_to_freq:9 Status is now "starting".
2024-11-03T14:34:06+0000 pid_to_freq:9 Status is now "running".
2024-11-03T14:34:06+0000 Setting state: ControlState.PIDToFreq(target_freq=2.0, direction='1', freq_tol=0.05, freq_tol_duration=10.0)
2024-11-03T14:34:06+0000 Error updating state:
Traceback (most recent call last):
  File "/opt/venv/lib/python3.10/site-packages/socs/agents/hwp_supervisor/agent.py", line 982, in update
    check_acu_ok_for_spinup()
  File "/opt/venv/lib/python3.10/site-packages/socs/agents/hwp_supervisor/agent.py", line 975, in check_acu_ok_for_spinup
    raise RuntimeError(f"ACU elevation is {acu.el_current_position} deg, "
RuntimeError: ACU elevation is 47.9998 deg, outside of allowed range (48.0, 90.0)

This has been encountered on satp2 and satp3. satp3 chose to loosen the limits in the configs by 1/10th of a degree. I think we should just set some acceptable tolerance on this check in the agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent: hwp supervisor bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants