Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess: Remove reliance on Peak-to-Peak cuts #980

Open
msilvafe opened this issue Oct 2, 2024 · 0 comments
Open

Preprocess: Remove reliance on Peak-to-Peak cuts #980

msilvafe opened this issue Oct 2, 2024 · 0 comments

Comments

@msilvafe
Copy link
Contributor

msilvafe commented Oct 2, 2024

Currently we are using a peak-to-peak cut that looks at the kurtosis of the distribution of the peak-to-peak of each TOD and cuts outlier detectors until the kurtosis is below some threshold. I see this as a bandaid that is mostly cutting detectors with jumps that aren't being properly flagged + fixed. Once we are more confident in our jump finding + fixing being tracked in issue #975 we need to re-evaluate the need for the peak-to-peak cuts and test if we can remove this step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant