No suggested facets when a column named 'value' is included

[rgieseke]

When a column named 'value' is included there are no suggested facets is shown as the query uses an alias of 'value'.

datasette/datasette/facets.py

Lines 168 to 174 in 452a587

	suggested_facet_sql = """
	select {column} as value, count(*) as n from (
	{sql}
	) where value is not null
	group by value
	limit {limit}
	""".format(

Currently the following is shown (from https://latest.datasette.io/fixtures/facetable)

When I add a column named 'value' only the JSON facets are processed.

I think that not using aliases could be a solution (except if someone wants to use a column named count(*) though this seems to be unlikely). I'll open a PR with that.

There is also a TODO with a similar question in the same file. I have not looked into that yet.

datasette/datasette/facets.py

Line 512 in 452a587

# TODO: does this query break if inner sql produces value or count columns?

[rgieseke]

Without aliases:

The proposed fix in #2209 also works when the 'value' column is actually facetable (just added another value in the 'value' column).