Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAL Server should extract token from query with "access_token" keyword #45

Open
TOFarmer opened this issue Feb 5, 2021 · 1 comment
Labels
Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.

Comments

@TOFarmer
Copy link
Contributor

TOFarmer commented Feb 5, 2021

Description

_extract_token_query checks for the token using the 'token' keyword. The OAuth 2.0 Authorization Framework: Bearer Token Usage requires the token to be passed in a query with the keyword 'access_token'.

Suggested fix

To allow for backwards compatibility, the token should be extracted with either 'access_token' or 'token', with the former taking precedence.

@TOFarmer TOFarmer added the Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases. label Feb 8, 2021
@TOFarmer
Copy link
Contributor Author

TOFarmer commented Feb 8, 2021

Set as Priority 1 as the SAL client only implements tokens in headers and there is low expectation that users will use their own access methods for accessing a SAL server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.
Projects
None yet
Development

No branches or pull requests

1 participant