Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract classes do not subclass ABC #48

Open
TOFarmer opened this issue Feb 7, 2021 · 0 comments
Open

Abstract classes do not subclass ABC #48

TOFarmer opened this issue Feb 7, 2021 · 0 comments
Labels
Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.

Comments

@TOFarmer
Copy link
Contributor

TOFarmer commented Feb 7, 2021

Description

AuthenticationProvider, Mask, Error, and DataClass are all abstract classes (i.e., have methods which raise NotImplementedError) but none of them subclass ABC or decorate the methods with abstractmethod. This means that these classes can be instantiated (although the abstract methods obviously cannot be called).
@TOFarmer TOFarmer added the Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases. label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TOFarmer