Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTree.post should raise exception if revision is passed as a query argument #56

Open
TOFarmer opened this issue Feb 10, 2021 · 0 comments
Open

DataTree.post should raise exception if revision is passed as a query argument #56

TOFarmer opened this issue Feb 10, 2021 · 0 comments
Labels
Bug Issues that report incorrect or undesirable behaviour(s) Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.

Comments

@TOFarmer
Copy link
Contributor

Summary

The documentation on putting and coping nodes does not include revision as a query argument: this implies it is not possible to put or copy (done within DataTree.post) to a node at a specific revision. However no exception is raised if revision is included as a query argument, and the revision is ignored; as revision appends to the path in DataTree.get operations, this is somewhat misleading behaviour.

Possible fixes

Raise an exception if revision is included with a POST request.
@TOFarmer TOFarmer added Bug Issues that report incorrect or undesirable behaviour(s) Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases. labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that report incorrect or undesirable behaviour(s) Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TOFarmer