Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception raised when SALClient given incorrect credentials could be clearer #64

Open
TOFarmer opened this issue Feb 19, 2021 · 0 comments
Open

Exception raised when SALClient given incorrect credentials could be clearer #64

TOFarmer opened this issue Feb 19, 2021 · 0 comments
Labels
Bug Issues that report incorrect or undesirable behaviour(s) Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.

Comments

@TOFarmer
Copy link
Contributor

TOFarmer commented Feb 19, 2021 •
edited
Loading

Summary

When invalid credentials are passed to SALClient.authenticate, the exception which is raised is sal.core.exception.InvalidResponse("The server did not return an authentication token"). It would be better if an AuthenticationFailed was raised.

Possible fixes

Ideally _handle_error could be used to address this, but raise an InvalidReponse if the response is both invalid and not a 401 error.
@TOFarmer TOFarmer added Bug Issues that report incorrect or undesirable behaviour(s) Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases. labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that report incorrect or undesirable behaviour(s) Priority: 1 EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TOFarmer