Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users when authenticating with server which does not require authentication #66

Open
TOFarmer opened this issue Feb 22, 2021 · 0 comments
Open

Warn users when authenticating with server which does not require authentication #66

TOFarmer opened this issue Feb 22, 2021 · 0 comments
Labels
Bug Issues that report incorrect or undesirable behaviour(s) Priority: 2 NORMAL: A task which is not critical and should be addressed when there are no higher priority issue

Comments

@TOFarmer
Copy link
Contributor

Summary

The SALClient should warn users if they attempt to authenticate with a server which does not require authentication.

Steps to reproduce

sc = SALClient(host)
sc.authenticate()

when sc.auth_required is False

What is the current bug behavior?

Nothing

What is the expected correct behavior?

UserWarning('Host does not require authentication. No authentication attempted.')

Possible fixes

Add warning!
@TOFarmer TOFarmer added Bug Issues that report incorrect or undesirable behaviour(s) Priority: Triage TRIAGE: Yet to be prioritized. Priority: 2 NORMAL: A task which is not critical and should be addressed when there are no higher priority issue and removed Priority: Triage TRIAGE: Yet to be prioritized. labels Feb 22, 2021
@TOFarmer TOFarmer mentioned this issue Feb 22, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that report incorrect or undesirable behaviour(s) Priority: 2 NORMAL: A task which is not critical and should be addressed when there are no higher priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TOFarmer