-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iphone safair support webkitEnterFullscreen. #221
Comments
Can you add webkitEnterFullscreen for supporting full screen mode for Iphones? |
+1 to this, not working on iphone |
+1 Much Needed, Currently have to work with |
+1 |
There seems to be a small bug in the screenfull code (lines 14 and 24): For apple / safari it uses But according to the apple documentation, safari not only requires the |
If I (or someone else) make a PR for this, is there any chance it would be merged? @ screenfull team |
+1 |
I will prepare a pr for this; only testing on ios is a little bit difficult for me. |
I have tested it on an iPhone with Safari 17.2 and based on my own experiments and on the official docs:
It makes little sense to me, since full screen is the default for the video element on the iPhone and you have to opt-out by specifying For other HTML elements, Long story short: Even if |
Perhaps I can help with a little web page that shows the fullscreen features available on 'your' browser. |
I don't get the point you are trying to make but here is a screenshot made on that iPhone with Safari 17.2 |
The page just proves that iPhone does not support the Fullscreen API (besides for HTMLVideoElement) as you said before and thus a or is useless. |
Why is that |
If you take a look at my testpage with an iPhone (I don't have one available): what does it say for 'webkitEnterFullscreen'? |
It says unavailable for all but i am trying to understand why ?, when i tested on iphone 12 pro on browserstack by attaching this api on the browser console it worked fine |
Ok, I think I understand. What this 'demopage' does is feature detection. for the fullscreen API. As webkitRequestFullscreen and webkitEnterFullscreen are features of an element, I test the availability for a "webkitRequestFullscreen" in window.document.createElement('div');
"webkitEnterFullscreen" in window.document.createElement('div'); Hope this helps. |
Iphone safair support webkitEnterFullscreen, not webkitRequestFullscreen
The text was updated successfully, but these errors were encountered: