Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the example #2249

Open
EchoEllet opened this issue Sep 19, 2024 · 0 comments
Open

Simplify the example #2249

EchoEllet opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@EchoEllet
Copy link
Collaborator

EchoEllet commented Sep 19, 2024

The example currently has different things that are not related to the project such as using bloc and hydrated_bloc only to save the state of the settings in the app storage. The settings itself should not be a thing, and the same thing for the home screen, we should be directly in the editor screen and then have the option to open different templates instead of having to choose a default template/sample to open, to save all of us time when writing step to reproduce a bug, avoid confusing the user, better hot reload experience on the web since it will reset the state of the app completely on each change, it should be focused on using the editor itself as it's in a real application, not related but the UI of the toolbar is not exactly the user experience we're looking for, especially on mobile, too many buttons that are not grouped and it take half of the screen, with our current state I don't plan on improving the simple toolbar provided with the package, instead will only provide it in the example app.

Android Example

We should not do anything in the example that we don't recommend the user to do, we already mentioned to not importing the file from the src directly especially if not exported but we're doing it in the example, currently, we're in the middle of other tasks, once done will fix this issue.

The only reason I remade this example in 2023 since the previous example implemented some features such as the image embed builder of the web on the example while mentioned in README it's a supported feature for the web, also some bug fixes were introduced only in the example and is not documented.

Also, we want to simplify the bug report template, we should not accept the code sample input and should be only tested on the example itself to save time for both developer and user.

@EchoEllet EchoEllet added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 19, 2024
@EchoEllet EchoEllet self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant