Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Refactor project code #26

Open
singodiyashubham87 opened this issue Nov 24, 2023 · 13 comments
Open

[ENHANCEMENT]: Refactor project code #26

singodiyashubham87 opened this issue Nov 24, 2023 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@singodiyashubham87
Copy link
Owner

Refactor the project code files without changing the functionality.

@singodiyashubham87 singodiyashubham87 added enhancement New feature or request good first issue Good for newcomers labels Nov 24, 2023
@JAYBORICHA07
Copy link
Contributor

@singodiyashubham87 Can you please give some more context or explain a bit more about the issue what are the issues in the current code?

@singodiyashubham87
Copy link
Owner Author

@JAYBORICHA07 I have assigned you an issue already, Have patience and once your PR is merged for that issue then I will explain and assign this issue to you.

@JAYBORICHA07
Copy link
Contributor

OKAY SIR THANK YOU

@lakshz
Copy link

lakshz commented Dec 1, 2023

Can you explain about the refactor more?

@singodiyashubham87
Copy link
Owner Author

@LakshyaSatpal Sure, Refactoring means restructuring and optimizing existing code without changing its external behaviour.

Remove redundant code
Simplify code logic(if possible)
Make code more readable(if there is need then only)

@sahilcodes-com
Copy link

can i work on this issue?

Abdelra6 pushed a commit to Abdelra6/ScrapeIt that referenced this issue Dec 14, 2023
* contribution guidelines added (singodiyashubham87#22)

* contribution guidelines added (singodiyashubham87#23)

* Ujjwal/contributing guide (singodiyashubham87#26)

* contribution guidelines added

* dev.to blog link added
@singodiyashubham87
Copy link
Owner Author

@Sahil-Choudhary-17 Go Ahead!

@sahilcodes-com
Copy link

The code is properly distributed in pages and components folder. Is there any specific part of the code base that you want me to refactor?

@singodiyashubham87
Copy link
Owner Author

@Sahil-Choudhary-17 See if you can optimize any part of the application, even small optimizations lead to big changes.
Check for redundant code, if it's there then remove it.

@singodiyashubham87
Copy link
Owner Author

@Sahil-Choudhary-17 Are you still working on the issue?

@sahilcodes-com
Copy link

No

@jayant-vashisth
Copy link

can i work on this? also do you have plan of expanding this app further, creating new modules etc?

@singodiyashubham87
Copy link
Owner Author

@jayant-vashisth I have no such plan for expanding.
And yes, you can work on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants