Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated zsktrs #73

Open
kousuke-nakano opened this issue Jul 16, 2023 · 1 comment
Open

duplicated zsktrs #73

kousuke-nakano opened this issue Jul 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kousuke-nakano
Copy link
Collaborator

kousuke-nakano commented Jul 16, 2023

Hi @addman2,

While I was refactoring, I noticed that the exactly same subroutine name "zsktrs" is used in

  • zsktrs_qp.f90, and
  • zsktrs.f90.

They both are included in CMakeLists.txt.

Do you think we can remove zsktrs.f90?

@kousuke-nakano kousuke-nakano self-assigned this Jul 16, 2023
@kousuke-nakano kousuke-nakano added the bug Something isn't working label Jul 16, 2023
@addman2
Copy link
Collaborator

addman2 commented Jul 16, 2023

Hi @kousuke-nakano

I know about zsktrs it is double complex skew symmetric solvers. The thing about qp is it has quadripole precision (which cannot be used with nvidia compiler) is used only by invertor zsktri which is then used in upnewwf or scratch det. Well good question is which one of these we would need, personally I would keep both and investigate latter why was quadripole precision needed. Verificarlo no would be very helpfull, unfortunatelly we dont have flang :-(.

Even bigger question is how the heck compilation work with these. There should be an error about double definition of subroutine. This is strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants