From 77e9ac9b0588da9057ad8d535ac61fc99096ba7d Mon Sep 17 00:00:00 2001 From: Peter Hedenskog Date: Wed, 18 Dec 2024 12:46:20 +0100 Subject: [PATCH 1/3] A more robust gnirehtet check (#2223) --- lib/core/engine/index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/core/engine/index.js b/lib/core/engine/index.js index c61c4b7a21..fa5b228de5 100644 --- a/lib/core/engine/index.js +++ b/lib/core/engine/index.js @@ -93,7 +93,7 @@ export class Engine { await android._init(); this.android = android; - if (options.gnirehtet) { + if (options.gnirehtet === true) { this.gnirehtet = new Gnirehtet(options); await this.gnirehtet.start(); } @@ -520,7 +520,7 @@ export class Engine { } } - if (options.gnirehtet && this.gnirehtet) { + if (options.gnirehtet === true && this.gnirehtet) { await this.gnirehtet.stop(); } From 6b8bd0ccad5740e500f712b0e15022547dea6e4a Mon Sep 17 00:00:00 2001 From: soulgalore Date: Wed, 18 Dec 2024 12:50:30 +0100 Subject: [PATCH 2/3] new release --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7964ab51e7..fb9d1f9293 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Browsertime changelog (we do [semantic versioning](https://semver.org)) +## 23.4.4 - 2024-12-18 +### Fixed +* A more robust gnirehtet check when you run your Android test [#2223](https://github.com/sitespeedio/browsertime/pull/2223). + ## 23.4.3 - 2024-12-11 ### Fixed * Update to USB power profiling 1.5.0 [#2221](https://github.com/sitespeedio/browsertime/pull/2221). From c83cb81d33587be6683fea471bf4f2cf9b545b16 Mon Sep 17 00:00:00 2001 From: soulgalore Date: Wed, 18 Dec 2024 12:51:03 +0100 Subject: [PATCH 3/3] 23.4.4 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2df1781715..d50bbfb1fc 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "browsertime", - "version": "23.4.3", + "version": "23.4.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "browsertime", - "version": "23.4.3", + "version": "23.4.4", "license": "MIT", "dependencies": { "@cypress/xvfb": "1.2.4", diff --git a/package.json b/package.json index 7d41060453..8e4fe1cffd 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "browsertime", "description": "Get performance metrics from your web page using Browsertime.", - "version": "23.4.3", + "version": "23.4.4", "bin": "./bin/browsertime.js", "type": "module", "types": "./types/scripting.d.ts",