Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoidScalingImages give recommended Size #3

Open
brettallred opened this issue Jan 26, 2018 · 3 comments
Open

avoidScalingImages give recommended Size #3

brettallred opened this issue Jan 26, 2018 · 3 comments

Comments

@brettallred
Copy link

It would be nice if we could recommend which size to make each image based on how it is displayed in the browser. Currently it simply states that the images are scaled by at least 100 pixels.

This image size data could then be given to a web team to resize the images or better yet fed into a tool (imageoptim api, etc) that could automatically download and resize the image for the user and allow them to simply override their images with the correct image size.

@soulgalore
Copy link
Member

Hi @brettallred hmm we collect the actual size, could it be we don't display it in the extra info field? I know we show it in sitespeed.io (from the coach) if you click the extra info button. Let me check later on if we missed to just show that.

best
Peter

@brettallred
Copy link
Author

brettallred commented Feb 2, 2018

screen shot 2018-02-01 at 8 42 54 pm

@soulgalore - There is an example from the coach from sitespeed.io . The console version of the coach is basically the same. The result could be something as simple as showing

http://mozr.com/wp-content/uploads/2017/11/cropped-logo-2.png => Recommended Size: 145px

Or something like that. I have jumped into the source code but if we figure this is something we want I could work on PR.

@soulgalore
Copy link
Member

Ah I see, yep a PR would be cool. But it will be very specific to the configured view port right, so it really depends?

Best
Peter

@soulgalore soulgalore transferred this issue from sitespeedio/coach Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants