Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch missing metrics #42

Open
soulgalore opened this issue Sep 9, 2021 · 3 comments
Open

Catch missing metrics #42

soulgalore opened this issue Sep 9, 2021 · 3 comments

Comments

@soulgalore
Copy link
Member

There's a case on our test server where we don't get data for CLS:

[2021-09-09 09:00:29] INFO: Got https://www.sitespeed.io/ analysed from Google Page Speed Insights
[2021-09-09 09:00:29] ERROR: TypeError: Cannot read property 'percentile' of undefined
    at Object.repackage (/gpsi/lib/pageSummary.js:68:70)
    at /gpsi/lib/index.js:93:50
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
@MasterGordon
Copy link

Any news on this issue, also recieving the same issune:

ERROR: TypeError: Cannot read properties of undefined (reading 'percentile')
    at repackageSummary (file:///gpsi/lib/summary.js:22:14)
    at file:///gpsi/lib/index.js:103:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Running the latest version (27.3.1-plus1) inside docker

@soulgalore
Copy link
Member Author

I guess we need to make a check for all metrics. In your case I could see that the site you are testing is missing First input delay metrics.

@soulgalore
Copy link
Member Author

Going out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants