Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to create a PR to add Async version #37

Open
DavidRomanovizc opened this issue Apr 13, 2024 · 3 comments
Open

I want to create a PR to add Async version #37

DavidRomanovizc opened this issue Apr 13, 2024 · 3 comments

Comments

@DavidRomanovizc
Copy link

I could add async version of Client

Is that desirable?

@sivakov512
Copy link
Owner

What you want to use as a basic client?

@DavidRomanovizc
Copy link
Author

What you want to use as a basic client?

I plan to use the aiohttp. And I see two possible implementation approaches:

  • Creating a separate file (e.g. async_client.py) and implement an AsyncClient class there.
  • Adding an AsyncClient class within the existing client.py.

@sivakov512
Copy link
Owner

sivakov512 commented Apr 13, 2024

I think option with separated file is better. I’m okay if you will make it as a package extra, so aiohttp will be an optional dependency.
If you have a time to do the same with synchronous client and request it would be really cool

@DavidRomanovizc DavidRomanovizc mentioned this issue Apr 15, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants