Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflections Ignore Fog #220

Open
adriansnetlis opened this issue Sep 12, 2024 · 0 comments
Open

Reflections Ignore Fog #220

adriansnetlis opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@adriansnetlis
Copy link

What happened?

2024-09-12_12 41 38
At the current moment the rendering appears to be done as follows:

  1. Render geometry, perhaps some post-process irrelevant to the issue
  2. Render screen-space reflections
  3. Render fog
  4. More post-process irrelevant to the issue

This, however, causes reflections to be too strong when reflecting distant objects as the fog isn't present on reflections.

I am wondering if it's possible to modify this as follows:

  1. Render geometry, perhaps some post-process irrelevant to the issue
  2. Render fog, plus have the fog/fog intensity available in separate buffer for other post-process effects
  3. Render screen-space reflections, additionally scaling them by the fog to ensure fogged objects don't have too strong of a reflection on them
  4. More post-process irrelevant to the issue

I am not fully familiar with MC shader API and what parts of render pipeline can be accessed, nor do I know how big of a performance effect having this extra buffed would have, but assuming it's possible and not expensive, this could help fix this artifact and improve the consistency of the shader.

Minecraft Version

Other

Which shader mod are you using?

Iris

Shader mod version

1.0a

Shader settings

#Thu Sep 12 12:36:24 AZOST 2024
AIR_FOG_COLORED_LIGHT_SHAFTS=true
AIR_FOG_MIE_DENSITY_BLUE_HOUR=0.0015
AIR_FOG_MIE_DENSITY_EVENING=0.0025
AIR_FOG_MIE_DENSITY_MIDNIGHT=0.0030
AIR_FOG_MIE_DENSITY_MORNING=0.0040
AIR_FOG_MIE_DENSITY_RAIN=0.020
AIR_FOG_RAYLEIGH_DENSITY=0.0004
AIR_FOG_RAYLEIGH_DENSITY_ARID=0.0002
AIR_FOG_RAYLEIGH_DENSITY_JUNGLE=0.0010
AIR_FOG_RAYLEIGH_DENSITY_SNOWY=0.0007
AIR_FOG_RAYLEIGH_DENSITY_SWAMP=0.0011
AIR_FOG_RAYLEIGH_DENSITY_TAIGA=0.0005
BLOOMY_FOG=false
CLOUDS_SCALE=3.0
COLORED_LIGHTS=true
ENTITY_SHADOWS=false
FXAA=false
HANDHELD_LIGHTING=true
MOON_ANGULAR_RADIUS=0.8
SH_SKYLIGHT=true
SKY_GROUND=true
SNELLS_WINDOW=true
SUN_ANGULAR_RADIUS=0.9
VANILLA_AO=false
WATER_CAUSTICS=true
WATER_TEXTURE=WATER_TEXTURE_OFF
WATER_WAVE_FREQUENCY=0.80
WATER_WAVE_LACUNARITY=1.10
WATER_WAVE_PERSISTENCE=0.90
WATER_WAVE_SPEED_STILL=0.60
WATER_WAVE_STRENGTH=0.70

Relevant log output

No response

@adriansnetlis adriansnetlis added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant