Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log excerpts should be properly escaped #62

Open
boosty opened this issue Apr 28, 2015 · 0 comments
Open

Log excerpts should be properly escaped #62

boosty opened this issue Apr 28, 2015 · 0 comments

Comments

@boosty
Copy link

boosty commented Apr 28, 2015

Currently the live stream and the error list views don't escape html specials chars (such as < > &) in the log excerpt correctly.

Example log line:

Riak client error: #<SocketError: Unexpected EOF on PBC socket> for #<Riak::Client::Beefcake>

The live stream does not seem to escape it at all (which could cause XSS):

Riak client error: # for #

The error list view seems to double-escape it:

Riak client error: #&lt;SocketError: Unexpected EOF on PBC socket&gt; for #&lt;Riak::Client::Beefcake&gt;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boosty