Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled state #2796

Open
bartduisters opened this issue Aug 9, 2024 · 1 comment
Open

Disabled state #2796

bartduisters opened this issue Aug 9, 2024 · 1 comment
Labels
feature request Request a feature or introduce and update to the project.
Milestone

Comments

@bartduisters
Copy link
Contributor

Describe the feature in detail (code, mocks, or screenshots encouraged)

cursor: not-allowed is not default behavior for disabled elements (cursor: default is)

It is not compatible with pointer-events: none when applied on the same element.

If you do want both, you would always need to apply cursor: not-allowed on a wrapper/container element and have the children be pointer-events: none.

For default html elements like button and select, this can be done with an overwrite:

:disabled {
  cursor: not-allowed;
}
:disabled > * {
  opacity: 0.5;
  pointer-events: none;
}

For Skeleton there probably needs to be a decision whether to follow browser defaults or apply cursor: not-allowed in a consistent way.

This ticket should be used to investigate it, the outcome would be a ticket to implement the consistency throughout the library.

What type of pull request would this be?

Enhancement

Provide relevant links or additional information.

No response

@bartduisters bartduisters added the feature request Request a feature or introduce and update to the project. label Aug 9, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Aug 9, 2024
@endigo9740
Copy link
Contributor

endigo9740 commented Aug 9, 2024

Note for myself: we set the disabled state styles within the plugin > core.css styles (aka global styles).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a feature or introduce and update to the project.
Projects
None yet
Development

No branches or pull requests

2 participants