Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider strange shadow and outlines #2853

Open
olmohake opened this issue Sep 12, 2024 · 2 comments
Open

Slider strange shadow and outlines #2853

olmohake opened this issue Sep 12, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@olmohake
Copy link

Current Behavior

using chrome on iOS 17.6.1 the button of the slider in the form displays a strange shadow: Bildschirmfoto_12-9-2024_152528_discord com

in the documentation for the slider component the button is displaying 2 outlines while active and 1 afterwards:Bildschirmfoto_12-9-2024_152511_discord com

Expected Behavior

no shadow & no outlines

Steps To Reproduce

No response

Link to Reproduction / Stackblitz

No response

More Information

No response

@olmohake olmohake added the bug Something isn't working label Sep 12, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Sep 12, 2024
@endigo9740 endigo9740 added the good first issue Good for newcomers label Nov 12, 2024
@endigo9740
Copy link
Contributor

endigo9740 commented Dec 5, 2024

Just acknowledging I can replicate both issues shown here. I'll be returning to this issue likely over the next week.

Per the Range Input element

We're currently applying the standard .input class to this component, and then refining the styles based on the type. However, this implements overflow:hidden which causes the native shadows on the drag handle to be clipped. So two possible solutions:

  1. Exempt overflow styles from the range type input
  2. Create a dedicated class specifically for styling these inputs, ex: input-range

NOTE: the former is preferred for ease of use and backwards compatibility.

Per the Skeleton Slider component

Focus states are something we've really struggled with for our Zag-based components. Zag takes a different mental model for how focus states should be handled (using global stylesheets and data attribute selectors), whereas we focus on direct utility classes.

I may group this issues into a larger sweeping audit and update dedicated to fixing known issues with focus states several of our components. This includes Segment.Item and Switch components.

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 6, 2024

Note we'll handle the <Slider> component fixes in this ticket:

This ticket will remain open specifically for the input range element styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants