Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 Input Group buttons are not affected by Presets #2985

Open
endigo9740 opened this issue Nov 19, 2024 · 2 comments
Open

v3 Input Group buttons are not affected by Presets #2985

endigo9740 opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Nov 19, 2024

Current Behavior

When creating an input group, the button styles do not display the Preset classes applied. Note that this is working on the Astro docs, but not in a real world SvelteKit project. Which might imply there's a precedence issue that only occurs during the final build process.

Screenshot 2024-11-19 at 1 38 42 PM

<form class="mx-auto w-full max-w-md space-y-8">
    <div class="input-group divide-surface-200-800 grid-cols-[auto_1fr_auto] divide-x">
        <div class="input-group-cell">S</div>
        <input type="search" placeholder="Search..." />
        <button class="btn preset-filled">Submit</button>
    </div>
</form>

Expected Behavior

You should be free to style the buttons however you wish.

Steps To Reproduce

  1. Create a new v3 SvelteKit project
  2. Copy/paste the examples from our docs
  3. Note the button styles do not match how they are show in the docs

Link to Reproduction / Stackblitz

No response

More Information

Docs: https://next.skeleton.dev/docs/tailwind/forms#groups

@endigo9740 endigo9740 added the bug Something isn't working label Nov 19, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Nov 19, 2024
@phamduylong
Copy link
Contributor

Ran through this a bit, it seems like some of the properties for the preset and .input-group in forms.css are overlapping, and this "race condition" is resolved differently in Astro docs and a real world project.

@endigo9740
Copy link
Contributor Author

@phamduylong that was my guess as well. I'm still not entirely happy with how the input groups are handled so leave this one to me. I'll try to revise before launch. Otherwise we might delay this feature to ensure I have proper time to implement breaking changes.

@endigo9740 endigo9740 self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants