Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup: CloseQuery has no effect, popup closes alway on click #3075

Open
Serveny opened this issue Dec 23, 2024 · 0 comments · May be fixed by #3076
Open

Popup: CloseQuery has no effect, popup closes alway on click #3075

Serveny opened this issue Dec 23, 2024 · 0 comments · May be fixed by #3076
Labels
bug Something isn't working
Milestone
v2.0

Comments

@Serveny
Copy link

Serveny commented Dec 23, 2024 •
edited
Loading

Current Behavior

The popup closes always when clicking on a item inside the popup.

Expected Behavior

The popup should only close on click on the selected item in the closeQuery parameter.

Steps To Reproduce

  1. Go to https://www.skeleton.dev/utilities/popups#close-query
  2. Scroll down to Close Query
  3. Click on Show Popup and then on the #wont-close button
  4. It closes but it should not

Link to Reproduction / Stackblitz

https://www.skeleton.dev/utilities/popups#close-query

More Information

Tested with Firefox & Chrome.

No response
@Serveny Serveny added the bug Something isn't working label Dec 23, 2024
@endigo9740 endigo9740 added this to the v2.0 milestone Dec 23, 2024
@phamduylong phamduylong mentioned this issue Dec 26, 2024
Merged
7 tasks
nullpointerexceptionkek added a commit to nullpointerexceptionkek/skeleton-v2 that referenced this issue Dec 26, 2024
@nullpointerexceptionkek
Bugfix/skeletonlabs#3075 CloseQuery has no efffect
b61784c
@nullpointerexceptionkek nullpointerexceptionkek linked a pull request Dec 26, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Bugfix: CloseQuery has no efffect/Popup close on click nullpointerexceptionkek/skeleton-v2
2 participants
@endigo9740 @Serveny