Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange buttons do the opposite of what they are supposed to #76

Open
Mxchaeltrxn opened this issue Feb 18, 2020 · 4 comments · May be fixed by #78
Open

Arrange buttons do the opposite of what they are supposed to #76

Mxchaeltrxn opened this issue Feb 18, 2020 · 4 comments · May be fixed by #78
Milestone

Comments

@Mxchaeltrxn
Copy link
Member

Mxchaeltrxn commented Feb 18, 2020

Problem

Pressing
image
causes the layer to move up.

Pressing
image
causes the layer to move down.

Fix

These should be switched around.

List layers in the layers panel in reverse order.

@Mxchaeltrxn Mxchaeltrxn changed the title Arrange buttons do the opposite of what they are supposed to. Arrange buttons do the opposite of what they are supposed to Feb 19, 2020
@haydn
Copy link
Member

haydn commented Feb 22, 2020

@Mxchaeltrxn This is a funny one! It's current behaviour is actually intentional… but that doesn't mean that it's correct.

When a user moves a layer forward it is correctly being moved in front of other layers on the canvas (it's component is rendered after the layers before it and therefore appears to be in front of it). What's perhaps "wrong" is that the layers are listed on the left in the same order which means the layer that's physically at the front is listed at the bottom.

Should we reverse the order the layers are listed in? I honestly don't know. Both Sketch and Figma render [turns out Figma does not] Sketch renders layer in that order "logical order" (it seems to be default in design tools these days), however the Adobe suite (Photoshop, Illustrator etc) all render the layers in their "physical order" instead. 🤷‍♀

@Mxchaeltrxn
Copy link
Member Author

@haydn After reading what you wrote, it seems that both behaviours are reasonable. However, I was not clear in my description because I was not aware of the button's complete functionality.

The bit that confuses me is the iconography and how it relates to its action. I wasn't actually sure what this button did when I saw it so I tried clicking it. I thought it was odd that the button with the downward pointing arrow moved the selected layer up in the left hand Layers column and the button upward pointing arrow did the opposite. I wasn't actually aware that it changed the layering of the layers until you told me. I couldn't find this behaviour in Figma in the browser so I couldn't compare so it could just be me misinterpreting the icon.

Perhaps labeling the section Arrange layering rather than Arrange might help because I thought Arrange meant Arrange in left hand Layers column?

@haydn
Copy link
Member

haydn commented Feb 23, 2020

Here's where the functionality exists in Figma:

image

Turns out I was wrong about Figma's behaviour — it does display the list of layers on the left in their physical order:

image

That seems like the best setup, I reckon we copy that behaviour.

I agree that "Arrange" isn't very intuitive — maybe the section could be called "Order"?

I'll update the issues original description with the new plan.

@Mxchaeltrxn
Copy link
Member Author

@haydn I like that. I can do this one!

@Mxchaeltrxn Mxchaeltrxn linked a pull request Feb 24, 2020 that will close this issue
@haydn haydn linked a pull request Apr 4, 2020 that will close this issue
@haydn haydn added this to the v0.4 milestone Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants