-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrange buttons do the opposite of what they are supposed to #76
Comments
@Mxchaeltrxn This is a funny one! It's current behaviour is actually intentional… but that doesn't mean that it's correct. When a user moves a layer forward it is correctly being moved in front of other layers on the canvas (it's component is rendered after the layers before it and therefore appears to be in front of it). What's perhaps "wrong" is that the layers are listed on the left in the same order which means the layer that's physically at the front is listed at the bottom. Should we reverse the order the layers are listed in? I honestly don't know. |
@haydn After reading what you wrote, it seems that both behaviours are reasonable. However, I was not clear in my description because I was not aware of the button's complete functionality. The bit that confuses me is the iconography and how it relates to its action. I wasn't actually sure what this button did when I saw it so I tried clicking it. I thought it was odd that the button with the downward pointing arrow moved the selected layer up in the left hand Perhaps labeling the section |
Here's where the functionality exists in Figma: Turns out I was wrong about Figma's behaviour — it does display the list of layers on the left in their physical order: That seems like the best setup, I reckon we copy that behaviour. I agree that "Arrange" isn't very intuitive — maybe the section could be called "Order"? I'll update the issues original description with the new plan. |
@haydn I like that. I can do this one! |
Problem
Pressing
causes the layer to move up.
Pressing
causes the layer to move down.
Fix
These should be switched around.List layers in the layers panel in reverse order.
The text was updated successfully, but these errors were encountered: