Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded view does not clean up WebGL when stopped. #77

Open
trusktr opened this issue Oct 18, 2018 · 1 comment
Open

embedded view does not clean up WebGL when stopped. #77

trusktr opened this issue Oct 18, 2018 · 1 comment

Comments

@trusktr
Copy link

trusktr commented Oct 18, 2018

Didn't know where to report, so reporting here.

The web viewer embed does not clean up scenes, so if there's many embeds on the same page, the whole page will become slower and slower until it is utterly not usable, despite having stopped the viewers by clicking the X at the top right.

Expected: When we click the X, it should stop the animation frames and stop rendering.

Actual: it keeps rendering the scenes, and it merely hides them with an overlay.

This uses an incredible amount of resources, for example, when trying to make a list of models with 3D thumbnails.

It'd be much appreciated if you could fix it. Thanks for the great product!

@Kuranes
Copy link
Contributor

Kuranes commented Oct 18, 2018

Thanks for the report, indeed, we didn't stop animation in this case.
We will fix that, so that CPU resources are lowered, thanks.
For the "unload whole scene", it's a not as easy, we'll check.

For bug report, the "report" button on model page works, it send to
https://help.sketchfab.com/hc/en-us/requests/new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants