Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic.Zip conflict after importing SketchfabForUnity v.1.2.0 into Unity 2021.1.6 #7

Open
kylereinfeld opened this issue May 6, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@kylereinfeld
Copy link

I'm getting four similar console errors after import. Example:

Library\PackageCache\[email protected]\Editor\VisualScripting.Core\Utilities\BackupUtility.cs(26,34): error CS0433: The type 'ZipFile' exists in both 'Ionic.Zip.Unity, Version=1.9.1.9000, Culture=neutral, PublicKeyToken=null' and 'Ionic.Zip, Version=1.9.1.8, Culture=neutral, PublicKeyToken=edbe51ad942a3f5c'

I tried importing the package with IonicZip unchecked, but that results in its own issues. Is there an easy workaround for this?

@AurL
Copy link
Contributor

AurL commented May 7, 2021

Thanks @kylereinfeld for reporting.
The log shows that the new VisualScripting feature also includes the Ionic.Zip but with a different version, which collide with the one distributed with our plugin.
There might be some adjustements to do in the code to make it fit with the Unity's default version.

We are going to investigate and provide a workaround before fixing it 👍

@kylereinfeld
Copy link
Author

Thanks @AurL. As soon as there's a workaround please feel free to let me know!

@AurL AurL added the bug Something isn't working label May 20, 2021
@michaelmarkman
Copy link

michaelmarkman commented Dec 15, 2021

Any updates on this? For now, I've disabled Visual Scripting in the package manager, which seems to be working.

@AurL
Copy link
Contributor

AurL commented Dec 16, 2021

@michaelmarkman It looks like we didn't come back to this when fixing the other dependency collision.
I don't reproduce the issue on Unity 2021.1.19f1 (with Visual Scripting 1.6.1), which versions do you have on your side ?

It also works for 2021.2.6f1 (with Visual Scripting 1.7.5), but I might be missing a detail.
Could you share your console error(s) to see if there is any other detail ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants