Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile won't build for all targets of zip recipe #2

Open
skibz opened this issue Dec 10, 2021 · 0 comments
Open

makefile won't build for all targets of zip recipe #2

skibz opened this issue Dec 10, 2021 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@skibz
Copy link
Owner

skibz commented Dec 10, 2021

this line of the makefile used to be

hnlists-firefox.zip hnlists-chrome: *.js *.png

and i had this faulty assumption that the recipe would be run for every target, but it always results in only the first target being built.

simplest solution to fixing this is to make separate recipes for each browser, and then a phony "all" target or whatever that gets executed with make all.

what i really want, though, is to have one recipe for all browser targets with which a single make command may be issued.

but ultimately, as soon as firefox begins to supports manifest v3, all of this will cease to be an issue as that's actually the only reason there are different zips being built per browser to begin with...

@skibz skibz added bug Something isn't working help wanted Extra attention is needed labels Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant