Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does monitor accept start/length instead of start/end? #15

Open
baileyparker opened this issue Mar 14, 2015 · 1 comment
Open

Why does monitor accept start/length instead of start/end? #15

baileyparker opened this issue Mar 14, 2015 · 1 comment

Comments

@baileyparker
Copy link
Contributor

Is there a reason why monitor takes a starting address and a length instead of a starting address and an ending address? It seems to me the latter would make more sense since you often know the starting and ending address of where your program modifies memory. This eliminates the need to do some hex subtraction to figure out the appropriate length.

This also makes monitoring the entire memory more intuitive in my opinion, since currently $0000 with length $ffff is missing memory location $ffff. To see the last memory location you need a length of $10000, which doesn't make sense given that all 6502 addresses are 2 bytes.

This came about when I discovered the bug detailed in #16.

@BigEd
Copy link
Collaborator

BigEd commented Jul 5, 2015

I agree that this could be done differently - one might even offer both alternatives and pick up the most recently changed one to compute the other. But I think it's aesthetic and a close call, and not really a bug. Feel free, of course, to put a good fix into your own branch. If you do allow both and if the code isn't too twisty, and it turns out to be quite intuitive to use, it might be good to merge it back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants