perf: Use Caching in Priority Nonce Mempool for Tx Look ups #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 52.12% 52.07% -0.05%
==========================================
Files 48 48
Lines 1861 1855 -6
==========================================
- Hits 970 966 -4
+ Misses 799 798 -1
+ Partials 92 91 -1 ☔ View full report in Codecov by Sentry. |
davidterpay
added
backport/v1.x.x
davidterpay
changed the title
aljo242
approved these changes
Jun 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* benchmark contains * use sender/nonce when caching * nit * nits * nit (cherry picked from commit 3376dd3) # Conflicts: # block/base/mempool.go # block/base/mempool_test.go
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* benchmark contains * use sender/nonce when caching * nit * nits * nit (cherry picked from commit 3376dd3) # Conflicts: # block/base/mempool_test.go
This was referenced Jun 18, 2024
Eric-Warehime
pushed a commit
that referenced
this pull request
Jun 19, 2024
…520) (#523) * perf: Use Caching in Priority Nonce Mempool for Tx Look ups (#520) * benchmark contains * use sender/nonce when caching * nit * nits * nit (cherry picked from commit 3376dd3) # Conflicts: # block/base/mempool.go # block/base/mempool_test.go * nit --------- Co-authored-by: David Terpay <[email protected]> Co-authored-by: David Terpay <[email protected]>
|
Shouldn't this use the signature as well for guaranteed uniqueness? |
davidterpay
added a commit
that referenced
this pull request
Jun 19, 2024
…520) (#524) * perf: Use Caching in Priority Nonce Mempool for Tx Look ups (#520) * benchmark contains * use sender/nonce when caching * nit * nits * nit (cherry picked from commit 3376dd3) # Conflicts: # block/base/mempool_test.go * nit --------- Co-authored-by: David Terpay <[email protected]> Co-authored-by: David Terpay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Optimization:
After Optimization:
