Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fees as BigInt instead of sdk.Coin #108

Open
davidterpay opened this issue May 3, 2023 · 2 comments
Open

Fees as BigInt instead of sdk.Coin #108

davidterpay opened this issue May 3, 2023 · 2 comments

Comments

@davidterpay
Copy link
Contributor

davidterpay commented May 3, 2023 •
edited
Loading

Since POB does not have multiple fee denominations, it probably makes more sense to simplify the interface and utilize BigInt instead. FWIW, this will definitely simplify integrations with EVM or other similar chains where expressing bids as sdk.Coins may not be trivial.
@itsdevbear
Copy link

@davidterpay you can use a comparable generic as well

https://go.dev/blog/comparable

@itsdevbear
Copy link

alternatively, we can define a custom Comparable interface and then write a small wrapper around sdk.Coins{} as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidterpay @itsdevbear