[BUG] error with pytorch_lightning import

[cbasisarifin]

Describe the bug

To Reproduce

i notice that the error came from "pytorch_forecasting\models\deepar\__init__.py" line 13
is the line "from pytorch_lightning.core.lightning import LightningModule" in line 13 can be change into
"from lightning import LightningModule"

are they both the same module?

Expected behavior

Additional context

Versions

[fkiraly]

Can you please add code to reproduce the error?

[benHeid]

pytorch-lightning is the old name. of lightning. Thus, only lightning should be used. However, in line 13 of the mentioned __init__ I do not see any import of lightning. However, there are multiple old links pointing to pytorch-lightning. These links are probably broken and we should replace them.

[fkiraly]

why are the tests not catching this?

[benHeid]

Because they are part of the docstrings. Do we test those links?

[cbasisarifin]

above is the version and the example screen shot after altered within folder "\site-packages\pytorch_forecasting\models\deepar"

above is the screenshot before altered

[benHeid]

This is an old version of PyTorch forecasting. Please try to update it.

[cbasisarifin]

thank you very much for the reply
however, i just copy and pasted the command directly from the webpage

i tried to upgrade them from Conda-forge directly,
but still not success, used chatgpt to guide me how to upgrade it, even worsen, got downgraded into version 0.5.3

and then chatgpt request me to check the version available in the conda forge

and this is the respon

is it safe to directly upgrade version via pip?

regards,
Chandra

[benHeid]

Oh try to install it with pip. @fkiraly do you know what's with the version on conda?

[cbasisarifin]

anyway
thanks for replying @benHeid and @fkiraly
happy new year 2025 wish you guys luck and healthy

anyway
just want to directly answer the last comment

but, i've manually install it via pip
now i will close the thread
thanks again @benHeid and @fkiraly
regards,
Chandra