Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NATs event Trigger (Step 3) #358

Open
grahamia opened this issue Aug 30, 2024 · 0 comments · May be fixed by #377
Open

Implement NATs event Trigger (Step 3) #358

grahamia opened this issue Aug 30, 2024 · 0 comments · May be fixed by #377
Assignees

Comments

@grahamia
Copy link
Contributor

grahamia commented Aug 30, 2024

Overview

Currently the webhook call from KFP Operator is a http call to an Argo events webhook.

This issue is to introduce a new component "NATs event trigger" with a gRPC interface, this service will process the request and produce the run completion message onto the eventbus.

Technical Details

Deployment needs to be added to helm and kustomize.
gRPC interface will need to contain all the same information as is currently in the http payload
First task will be to defined the protobuf file for the service to include the following:

        "specversion": "1.0",
        "id": "123",
        "source": "vai",
        "type": "org.kubeflow.pipelines.run-completion",
        "datacontenttype": "application/json",
        "data": {
            "pipelineName": "pipelinename",
            "provider": "vai",
            "runConfigurationName": "runcomfigname",
            "runId": "runIdFromVAI",
            "runName": "runname",
            "servingModelArtifacts": [
                {
                    "location": "some_location",
                    "name": "pushed_model"
                }
            ],
            "status": "succeeded"
        }

Message put onto NATs eventbus should be same as current message.
Location of NATs eventbus should be configurable.

Current Architecture

image

After Architecture

image

Acceptance Criteria

Eventing feedback should function as currently with no change
Testing should be carried out to ensure that same retry logic on failure exists and at least once consistency is maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants