Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for github discussions #1336

Open
riedel opened this issue Jun 30, 2024 · 4 comments
Open

Support for github discussions #1336

riedel opened this issue Jun 30, 2024 · 4 comments

Comments

@riedel
Copy link

riedel commented Jun 30, 2024

New discussion entries are shown in notifications but are not clickable.

At least opening the web page would be great, however, they are not much different from issue comments.

@Fs00
Copy link
Contributor

Fs00 commented Jul 7, 2024

As much as I'd like to implement support for discussion notifications, the GitHub API doesn't yet provide the data we need.
I sent a feature request some time ago but they haven't done anything about it yet. Feel free to upvote it to try and get their attention 🙏

@ihatemakinganaccount
Copy link

@Fs00 would it be possible to add discussions just as a feature/tab/screen on those hubs that have them, even if not directly clickable from a notification? Or am I just stupid, but I've not found a way to see discussions from OD.

I've also seen topics that were converted from issues to discussions, where in OD they show up only up to the point of being converted, at which point they appear as if locked by a bot.

@Fs00
Copy link
Contributor

Fs00 commented Jul 16, 2024

Implementing full support for discussions in the app (like we have for issues and pull requests) is surely possible but would be a pretty big task and I personally don't have much time and motivation for doing that.
A simpler addition that shouldn't take much work could be a "Discussions" shortcut in the repository "About" tab (displayed only for repos that have them) that opens the discussions page in the browser.

I've also seen topics that were converted from issues to discussions, where in OD they show up only up to the point of being converted

This is another case of the GitHub API endpoint we use not returning the data we need... 😔
The solution would be to reimplement issue/PR timeline fetching to use the newer GraphQL API, but it's a lot of work.

@Cwpute
Copy link

Cwpute commented Jul 18, 2024

A simpler addition that shouldn't take much work could be a "Discussions" shortcut in the repository "About" tab (displayed only for repos that have them) that opens the discussions page in the browser.

That would be a perfectly valid workaround, until the API allows for full support. I'd pirsonally prefer it being opened in my browser of choice, but directly inside the app is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants