Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: avoid saving the count in localStorage #60

Open
ronny1020 opened this issue Sep 20, 2023 · 1 comment
Open

Suggestion: avoid saving the count in localStorage #60

ronny1020 opened this issue Sep 20, 2023 · 1 comment

Comments

@ronny1020
Copy link

I want to start by saying thanks for the excellent work you've done. It's been a valuable tool for me.

I'd like to suggest a change regarding how the count number is stored. Currently, you're using localStorage, which caused an issue for me. I tried setting the count to 1024000, which led to a crash as expected. However, what's more concerning is that even after reloading the web page, it continued to crash repeatedly. Due to JavaScript's single-threaded nature, it is difficult to change the count to a smaller number.

Could you consider storing the count in an alternative approach such as URL search parameters? This change might help prevent such crashes.

@gnykka
Copy link
Collaborator

gnykka commented Sep 25, 2023

Yeah, using a URL search parameter is a good idea!
At first LocalStorage was useful in switching and comparing the same amounts. But with huge counts like 100k it's better to get rid of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants