-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close Hint On Element Click #45
Comments
Hi, thanks for raising this issue. Indeed, currently, it doesn't hide the hint in case of triggering the same event. Initially, the API was made for You are right, it makes sense to hide the hint on click if it's already shown, but this change breaks compatibility and might affect someone else's code and I would like to avoid it. As you've mentioned the only suitable way, for now, is to use I am working on the next API, it's halfway there, but I would like to get as much feedback as possible about all the inconveniences with the current API and have a proper discussion around the new API. If you could join the discussion it would be awesome: #46 |
Absolutely! Thanks for comment @slmgc! |
Is a v4 happening, which this would be a part of? |
@tonypee it is happening, I would like to close this deal within April |
@slmgc Great! Hope to get to play with it soon! |
If only the "click" event is set to true, it seems as though clicking an element with
data-rh
works to open the hint but clicking it again does not close the hint.I can wire up
toggleHint
from the ref, but it seems like the default here should be to close hint if the element is clicked again. Ifpersist
is set to true then it shouldn't close on click. At least that's how I interpret it.The text was updated successfully, but these errors were encountered: