Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRawValue doesn't look at the raw value #1053

Open
shawkins opened this issue Nov 16, 2023 · 1 comment
Open

getRawValue doesn't look at the raw value #1053

shawkins opened this issue Nov 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@shawkins
Copy link
Contributor

Is this correct -

return configValue != null && configValue.getValue() != null ? configValue.getValue() : null;

It seems like it should consult the raw value, or have some javadocs redefining what raw means for this method.

@radcortez
Copy link
Member

Yes, it is correct. The names are a bit unfortunate. getRawValue is part of the API since the early versions and the intent is to provide the value of the configuration before applying conversions.

Expressions and ConfigValue came later, requiring a way to access the value without expansion, which also got the name getRawValue.

@radcortez radcortez added the enhancement New feature or request label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants