Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Comparison View: Untriaged Issues #159

Closed
smarr opened this issue Jul 12, 2023 · 1 comment · Fixed by #164
Closed

New Comparison View: Untriaged Issues #159

smarr opened this issue Jul 12, 2023 · 1 comment · Fixed by #164

Comments

@smarr
Copy link
Owner

smarr commented Jul 12, 2023

ReBenchDB/src/backend/compare/html/stats-row-buttons-info.html:21
      19|       const baseTrial = d.profileTrialIdBase.trialid;
      20|       const changeTrial = d.profileTrialIdChange.trialid;
   >> 21| %}<button type="button" class="btn btn-sm btn-profile" data-content="{%= f.dataSeriesIds(d.dataSeries, d.profileTrialIdBase.runid, baseTrial, changeTrial) %}"></button>
      22| {%
      23|    }
      24| %}<button type="button" class="btn btn-sm btn-timeline" data-content='{%- JSON.stringify(
  
  Cannot read properties of undefined (reading 'base')
      at Module.dataSeriesIds (ReBenchDB/src/shared/data-format.ts:129:21)
      at eval ("ReBenchDB/src/backend/compare/html/stats-row-buttons-info.html":48:28)
      at stats-row-buttons-info (ReBenchDB/node_modules/ejs/lib/ejs.js:703:17)
      at include (ReBenchDB/node_modules/ejs/lib/ejs.js:701:39)
      at eval ("ReBenchDB/src/backend/compare/html/stats-row.html":109:17)
      at stats-row (ReBenchDB/node_modules/ejs/lib/ejs.js:703:17)
      at include (ReBenchDB/node_modules/ejs/lib/ejs.js:701:39)
      at eval ("ReBenchDB/src/backend/compare/html/stats-tbl.html":21:19)
      at stats-tbl (ReBenchDB/node_modules/ejs/lib/ejs.js:703:17)
      at include (ReBenchDB/node_modules/ejs/lib/ejs.js:701:39)
@smarr
Copy link
Owner Author

smarr commented Jul 18, 2023

Resolved by #164

@smarr smarr closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant