Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dendropy v4.6.0 causing SEPP to break #125

Closed
berkelem opened this issue Apr 28, 2023 · 10 comments
Closed

Dendropy v4.6.0 causing SEPP to break #125

berkelem opened this issue Apr 28, 2023 · 10 comments

Comments

@berkelem
Copy link

A new version of Dendropy was released a week ago and it is causing the SEPP conda build to break. Could you look into this and either update SEPP to maintain compatibility or update the conda recipe to restrict it to older versions of Dendropy?

@ncolaian
Copy link

I think I am having the same problem. I keep getting this error -
ImportError: cannot import name '_convert_node_to_root_polytomy' from 'dendropy.datamodel.treemodel'

@lh3
Copy link

lh3 commented May 19, 2023

CC @mmore500

@mmore500
Copy link
Contributor

Taking a look!

@mmore500
Copy link
Contributor

Opened #126 with a patch for sepp and made note of the fact that this logic is currently only accessible via "private" (i.e., _*) interface in dendropy (jeetsukumaran/DendroPy#169). Will contribute another patch once we create and release a public interface for _convert_node_to_root_polytomy. :)

@nicolo-tellini
Copy link

Hello,

I am having the same issue :
ImportError: cannot import name '_convert_node_to_root_polytomy' from 'dendropy.datamodel.treemodel'

any solution for that ?

@mmore500
Copy link
Contributor

Hi @nicolo-tellini

Pinning dendropy==4.5.2 within your runtime environment should fix this issue. You’l need to use your package manager (pip, poetry, conda, etc.) to accomplish this.

@nicolo-tellini
Copy link

Hi @mmore500 ,

thank you very much it works nicely

best

nic

@smirarab
Copy link
Owner

@mmore500 Thanks a ton for your PR and sorry I am so slow these days with these. I hope the merged PR fixes the issue?

@mmore500
Copy link
Contributor

mmore500 commented Feb 25, 2024

Yes! Thank you @smirarab :)

I don't have a button to close this issue, but if you do it should be able to be closed

@smirarab
Copy link
Owner

I also decided to make sepp backward compatible with dendropy <4.5.2. Fixed in 4.5.5. b3b3305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants