Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Min and Max do anything? #222

Open
pcolby opened this issue Jul 17, 2023 · 1 comment
Open

Do Min and Max do anything? #222

pcolby opened this issue Jul 17, 2023 · 1 comment

Comments

@pcolby
Copy link
Contributor

pcolby commented Jul 17, 2023

If I do:

    {
      "TableSchema": "<redacted>",
      "TableName": "<redacted>",
      "ColumnName": "<redacted>",
      "DataType": "text",
      ...
      "IsNullable": true,
      "Processors": [
        {
          "Name": "RandomDigits",
          "Max": 4,
          "Min": 2,
          "Variance": 0,
          "Comment": ""
        }
      ]
    },

Then Gonymizer randomises the digits in the relevant column, but does not seem to apply Min and Max in any way. I've had a quick scan of the code, and can't see anywhere those parameters are being applied, but I'm also not a Go expert 😄

Thanks.

@junkert
Copy link
Collaborator

junkert commented Jul 19, 2023

Hi @pcolby, they were meant to be used by the AlphaNumericScrambler, but it is possible it was broken by accident during a refactor or removed by accident. It should be pretty easy to add this back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants