Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol tests for routing failures #2348

Open
david-perez opened this issue Jul 9, 2024 · 1 comment
Open

Protocol tests for routing failures #2348

david-perez opened this issue Jul 9, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. server This issue involves the specification for server software.

Comments

@david-perez
Copy link
Contributor

david-perez commented Jul 9, 2024

There is no coverage in protocol tests when routing fails, across all protocols. This is something that can be remediated by designing a good test suite that exercises ambiguous routing decisions with @httpMalformedRequestTests.

The specs also do not prescribe what responses when routing fails should look like. Things like setting X-Amzn-ErrorType to UnknownOperationException for AWS JSON 1.x protocols should be documented, what HTTP status codes to use, what the body should look like, what headers (e.g. Content-Type) to set, etc.

@david-perez
Copy link
Contributor Author

david-perez commented Jul 9, 2024

Ideally this gets tackled after Smithy reifies the concept of "framework-level errors" (#2349) in the spec, so we can refer to things like the UnknownOperationException shape; i.e. vend this model from Smithy and modify the specs to refer to those shapes when framework-level errors occur.

@sugmanue sugmanue added the feature-request A feature should be added or improved. label Jul 23, 2024
@kstich kstich added the server This issue involves the specification for server software. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. server This issue involves the specification for server software.
Projects
None yet
Development

No branches or pull requests

3 participants