crossing missing from upstream access report bcfishpass.crossings_upstream_access

[smnorris]

Wilsey Spillway Dam is missing from the report output:

select ch_cm_co_pk_sk_belowupstrbarriers_network_km  from bcfishpass.crossings_upstream_access where aggregated_crossings_id = 'd5264acf-917b-43af-9c31-14d70733f81c';
 ch_cm_co_pk_sk_belowupstrbarriers_network_km
----------------------------------------------
(0 rows)

It is present in the upstream habitat report.

[smnorris]

This is a point to stream join issue. The inner join to streams in the at_point CTE is the issue : https://github.com/smnorris/bcfishpass/blob/access_report/model/01_access/sql/crossings_upstream_access_load.sql#L91

Modifying this to a left join might be all that is required but a much better fix would be to add a gradient at point function to fwapg as per smnorris/fwapg#142 rather than trying to get the gradient from two different stream segments.

[smnorris]

fixed with 821ca9d