Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated raw function monomorphizations #78

Open
smalis-msft opened this issue Jun 6, 2024 · 0 comments
Open

Duplicated raw function monomorphizations #78

smalis-msft opened this issue Jun 6, 2024 · 0 comments

Comments

@smalis-msft
Copy link

I stumbled on https://github.com/davidlattimore/duplicate-function-checker today and ran it over a relatively large work project that contains heavy use of async-task. Despite building our binary with fat LTO and 1 codegen-unit the tool output that the biggest duplicates in our binary by far were from 4 async-task raw functions: wake, drop_waker, drop_ref, and destroy. It may be worth looking at these functions to see if any pieces can be outlined so that they don't end up duplicated.

@smalis-msft smalis-msft changed the title Duplicate raw function monomorphizations Duplicated raw function monomorphizations Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant