Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N+1 Query on All Events menu / Refactor Code #312

Open
1 of 2 tasks
cycomachead opened this issue Mar 8, 2023 · 0 comments
Open
1 of 2 tasks

N+1 Query on All Events menu / Refactor Code #312

cycomachead opened this issue Mar 8, 2023 · 0 comments

Comments

@cycomachead
Copy link
Member

I'm submitting a ..

  • Bug Report
  • Feature Request

Current behavior:
The all events menu has an N+1 query for the splashpage of each conference.

Expected correct behavior:
We should include / pluck just the public column from the splashpage.
Additionally, I think we can simplify the code so that it doesn't need to be aware of the current user...

Finally, there shouldn't be an additional empty divider in the menu.

Steps to reproduce:

Other information:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cycomachead