Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Changes in the sync process #118

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

soumyaDghosh
Copy link
Member

  1. Remove the need of a python file to fetch the version, url
  2. Added codename into the version (closes [Snap store page] Please tell us the animal names #110 )

1. Remove the need of a python file to fetch the version, url
2. Added codename into the version (closes snapcrafters#110)
@soumyaDghosh soumyaDghosh marked this pull request as draft December 7, 2023 14:04
@soumyaDghosh soumyaDghosh marked this pull request as ready for review December 7, 2023 14:05
@merlijn-sebrechts
Copy link
Member

I wonder, android studio has an internal update checker. Is there any way to find out what URL that uses? Maybe we could use the same url instead of these oneliners

@soumyaDghosh
Copy link
Member Author

@merlijn-sebrechts

image

It's showing that the updates are managed by Snap.

@merlijn-sebrechts
Copy link
Member

can you update your PR to get the latest update version and name from https://dl.google.com/android/studio/patches/updates.xml?

This is what the app uses when installed without snap, so this will be long-term stable. You just need to parse the XML.
should be easy to get it from this tag: <build apiVersion="AI-231.9392.1" number="AI-231.9392.1.2311.11076708" version="Hedgehog | 2023.1.1">

@soumyaDghosh
Copy link
Member Author

can you update your PR to get the latest update version and name from https://dl.google.com/android/studio/patches/updates.xml?

This url doesn't show the actual version number and the url to download. I'd still need to have a separate url to get the actual version number which is currently 2023.1.1.26

Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's get this running now, and try to find a better way to get the version in the future.

@merlijn-sebrechts merlijn-sebrechts merged commit 6dc53de into snapcrafters:candidate Dec 12, 2023
1 check passed
@merlijn-sebrechts
Copy link
Member

@soumyaDghosh seems like there is still an issue in the process: https://github.com/snapcrafters/android-studio/actions/runs/7193616466/job/19592441198

@soumyaDghosh
Copy link
Member Author

soumyaDghosh commented Dec 13, 2023

I have been looking into it from yesterday. And what I am thinking is, the url has / in it, which is probably confusing the sed command. I can't found any answer for it other than this.

EDIT: I can confirm this now.

@soumyaDghosh
Copy link
Member Author

Temporarily.. should we shift to yq?

@merlijn-sebrechts
Copy link
Member

Sure!

@jnsgruk
Copy link
Member

jnsgruk commented Dec 15, 2023

I commented on #120, but sed can be used with any separator to get around this, so you can do:

sed -i 's|foo|bar' or sed -i 's#foo#bar' etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Snap store page] Please tell us the animal names
3 participants