Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workflow]: remove the space and add - in the version #121

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[workflow]: remove the space and add - in the version #121

merged 1 commit into from
Dec 15, 2023

Conversation

soumyaDghosh
Copy link
Member

Snapcraft doesn't like space in the version string :-(

@soumyaDghosh
[workflow]: remove the space and add - in the version
ba63912 
Snapcraft doesn't like space in the `version` string :-(
@jnsgruk
Copy link
Member

jnsgruk commented Dec 15, 2023

Do we even need the codename in the version? Why not just the numerical version?

@soumyaDghosh
Copy link
Member Author

soumyaDghosh commented Dec 15, 2023 •
edited
Loading

User demand #110

jnsgruk
jnsgruk approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jnsgruk jnsgruk merged commit 2f97579 into snapcrafters:candidate Dec 15, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsgruk jnsgruk jnsgruk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumyaDghosh @jnsgruk