You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the same way that there is a Walk function for both the native file system (filepath.WalkDir) and virtual file system (fs.WalkDir), we should aim to support both of these in traverse. Up to now, I wasn't fully aware of the very significant but subtle differences between the two, resulting in an accidentally confused hybrid between the two. So currently, we only have an implementation for virtual file system but this is fully baked into the implementation without an intermediate abstraction.
This issue will simply ensure that the current support for the virtual fs is abstracted so that clear support for the local file system can be added by another issue.
The fileSystems object needs to be abstracted away with some kind of adapter, so that it can be substitued by a composite fs or afero. Also, each individual internal fs type needs to be replaceable by any of the afero interface types, so this could be tricky, but necessary. Actually, we should internally support our internal interfaces and then write afero adapters which translate these internal calls into afero calls.
The text was updated successfully, but these errors were encountered:
In the same way that there is a Walk function for both the native file system (filepath.WalkDir) and virtual file system (fs.WalkDir), we should aim to support both of these in traverse. Up to now, I wasn't fully aware of the very significant but subtle differences between the two, resulting in an accidentally confused hybrid between the two. So currently, we only have an implementation for virtual file system but this is fully baked into the implementation without an intermediate abstraction.
This issue will simply ensure that the current support for the virtual fs is abstracted so that clear support for the local file system can be added by another issue.
The fileSystems object needs to be abstracted away with some kind of adapter, so that it can be substitued by a composite fs or afero. Also, each individual internal fs type needs to be replaceable by any of the afero interface types, so this could be tricky, but necessary. Actually, we should internally support our internal interfaces and then write afero adapters which translate these internal calls into afero calls.
The text was updated successfully, but these errors were encountered: