This repository has been archived by the owner on Dec 2, 2018. It is now read-only.

Add options for getUserDisplayName #6

Open

3 tasks

brawaru opened this issue Oct 4, 2018 · 1 comment

Assignees

Labels

enhancement under-consideration

Member

brawaru commented Oct 4, 2018 •

edited

Loading

Add options to getUserDisplayName function instead of bunch of arguments:

includeTag ⇒ tag (boolean?)
includeAt ⇒ at (boolean?)
id (boolean?)

~~Or maybe replace with argument include which is Array of DisplayOption:~~

type DisplayOption = "tag" | "at" | "id";

First variant is more performant though.

The text was updated successfully, but these errors were encountered:

brawaru added the under-consideration label

brawaru self-assigned this

Member Author

brawaru commented Oct 4, 2018

ID will require to provide language code then, as it may differ per languages?
So it will better to stick with the first variant.

language (boolean?)

brawaru added the enhancement label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.