Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions in README to not to use a space-containing dir on Windows #395

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

sfc-gh-dszmolka
Copy link
Contributor

This is a document-only change.

Apparently the version of php-sdk-binary-tools/phpsdk-starter.bat what we use bails out with <token> was unexpected at this time. where <token>is the first string following the first space in the path to the script.
E.g. running the script from C:\temp\directory **name** with spaces\pdo_snowflake\scripts will yield '**name** was unexpected at this time'

Per issues found in the source repo on what we rely, this is known and indeed not supported.
So documenting it.

Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mhofman
Copy link
Collaborator

I'm forcing merge of this PR since it's just a doc change. cc @sfc-gh-dszmolka

@sfc-gh-mhofman sfc-gh-mhofman merged commit 828e684 into master Aug 26, 2024
6 of 13 checks passed
@sfc-gh-mhofman sfc-gh-mhofman deleted the windows-no-spaces-in-dirname branch August 26, 2024 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants