Merge v2 entities into template context instead of overriding #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+301
to
+304
| entities = { | ||
| k: e.model_dump(exclude_none=True, warnings=False, by_alias=True) | ||
| for k, e in pdfv2.entities.items() | ||
| } |
There was a problem hiding this comment.
It feels like that's not the right fix, since it can introduce a different behaviour once the contexts are merged (granted, I can't think of a way to trigger this with a valid set of templates, but still...). I expected we'd instead preserve the entire v1 context, separately, and decide at expansion time which of the contexts should apply. I'm still thinking through what it means to merge the contexts though, so I might be off here.
|
Closing in favour of #1735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
When converting PDFv1 to PDFv2 in-memory, we need to keep the v1 template context available since the user could have other files with templates still using v1 references in it, but we also need to have access to the generated v2 entities since converted package scripts refer to the package identifier, so let's merge them together. The proper solution would be to convert the whole project to v2, templates included, but that's a separate issue.